Add bundle download for repository #14538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
jolheiser
added
the
type/feature
zeripath
approved these changes
Feb 7, 2021
GiteaBot
added
the
lgtm/need 1
Closed
|
Please resolve the conflicts. |
# Conflicts: # routers/web/repo/repo.go # services/archiver/archiver.go # templates/repo/home.tmpl
Signed-off-by: jolheiser <john.olheiser@gmail.com>
|
This should be ready to test again.
|
|
Since .zip and .tar.gz will only include current branch codes, it's confusing that this will bundle --all. Maybe add two menu items, one is for current branch another is --all. |
Signed-off-by: jolheiser <john.olheiser@gmail.com>
|
Alright, this now downloads a bundle at the current branch/commit. After merging, I will follow up with a PR that adds the |
Codecov Report
@@ Coverage Diff @@
## main #14538 +/- ##
==========================================
- Coverage 45.50% 45.49% -0.01%
==========================================
Files 762 762
Lines 85940 85973 +33
==========================================
+ Hits 39108 39117 +9
- Misses 40521 40546 +25
+ Partials 6311 6310 -1
Continue to review full report at Codecov.
|
lunny
approved these changes
Aug 24, 2021
GiteaBot
added
lgtm/done
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds another download type for repositories, bundle.
This currently always bundles using
--all, since I'd imagine it's almost always more useful to have the entire repo history.In the future, bundling could be considered for backups since they are standalone repositories, more or less.
One thing that I couldn't seem to shake when writing this, it seems like the bundle file refused to copy correctly unless I closed the file after creation (and subsequently re-opened to allow the
io.Copy).Please let me know if I missed something silly. 🙂